Skip to content

[Fix] Skip DLCs when listing recently played games #2888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 24, 2023

Conversation

arielj
Copy link
Collaborator

@arielj arielj commented Jul 24, 2023

In the new version of Heroic we are properly ignoring DLCs in listings, but in previous versions you can still click Play in a DLC and it will fail but the game is still added in the Recently played list.

Because we are now hiding DLCs properly, if the element happens to be the first in the list, it's ignored but then the feature to display the first element bigger breaks because the indexes change and the justPlayed class is not set, and there's no way to remove the non-visible element from the list to manually fix the issue (apart from editing the config files manually).

This PR fixes that by ignoring DLCs when getting the list of recently played games.


Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@arielj arielj added the pr:ready-for-review Feature-complete, ready for the grind! :P label Jul 24, 2023
@arielj arielj requested review from a team, flavioislima, CommandMC, Nocccer and imLinguin and removed request for a team July 24, 2023 02:27
@arielj arielj added this to the 2.9 milestone Jul 24, 2023
@arielj arielj changed the title Skip DLCs when listing recently played games [Fix] Skip DLCs when listing recently played games Jul 24, 2023
@flavioislima flavioislima merged commit 7547364 into main Jul 24, 2023
@flavioislima flavioislima deleted the fix-ignore-dlcs-in-recently-played branch July 24, 2023 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:ready-for-review Feature-complete, ready for the grind! :P
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants